Add check_tbl_derived_task_id_vals() function
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are valid. Resolves #110
annakrystalli
commented
Dec 11, 2024
| file_path = "flu-base/2022-10-22-flu-base.csv", | ||
| skip_submit_window_check = TRUE | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Removed this because of the introduction of the new check, now when derived_task_ids are NULL the check is skipped and a message returned whereas if derived_task_ids are included, the result of the check is retuned. Hence these two situations do not return the same result anymore
zkamvar
approved these changes
Dec 12, 2024
|
Thanks @zkamvar ! Feel free to push forward with suggestions and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
check_tbl_derived_task_id_vals()check tovalidate_model_data()that ensures that values in derived task ID columns match expected values for the corresponding derived task IDs in the round as defined intasks.jsonconfig Given the dependence of derived task IDs on the values of other values, the check ignores the combinations of derived task ID values with those of other task IDs and focuses only on identifying values that do not match corresponding accepted values. This ensuresderived_task_idsvalues which are ignored in all other standard value checks receive atl east some basic validation.Resolves #110